Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button Group Buttons Triggering Form Submit After Upgrading #4360

Closed
skerry3000 opened this issue Dec 7, 2020 · 1 comment · Fixed by #4368
Closed

Button Group Buttons Triggering Form Submit After Upgrading #4360

skerry3000 opened this issue Dec 7, 2020 · 1 comment · Fixed by #4368

Comments

@skerry3000
Copy link
Contributor

Hello All,

I noticed my button group buttons are now submitting my form when I click them (I recently upgrading 29.4.x to 30.5.x. I believe this is related to this commit: 9e55637#diff-0006e261d91cfc0baa5577b8831164cb82ef31537b4d3f8df9df4d9efd6134f3

Specifically, there was some work done to move away from toggle, button and toward a new ButtonGroupButton component. Now the type is not being passed along, which I believe causes all these buttons to be submit buttons.

Let me know what you all think. I am happy to submit a PR for a fix if we agree.
@cchaos
Copy link
Contributor

cchaos commented Dec 7, 2020

Good catch. It looks like we need to explicitly pass type="button" to the EuiButtonDisplay used in EuiButtonGroupButton with the allowance to override. We'd be happy to review a PR!

@skerry3000 skerry3000 mentioned this issue Dec 8, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cchaos @skerry3000