Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiTreeView] [EuiTreeViewNode] Allow for label types other than string #4323

Closed
prcdpr opened this issue Nov 30, 2020 · 3 comments · Fixed by #4352
Closed

[EuiTreeView] [EuiTreeViewNode] Allow for label types other than string #4323

prcdpr opened this issue Nov 30, 2020 · 3 comments · Fixed by #4352
Labels
good first issue

Comments

@prcdpr
Copy link

prcdpr commented Nov 30, 2020 •
edited
Loading

https://elastic.github.io/eui/#/navigation/tree-view

Currently EuiTreeViewNode allows for labels being only string. I would like to put a formatted <span> here but currently it seems to be impossible.

image
@Dishebh
Copy link
Contributor

Dishebh commented Dec 4, 2020

@prcdpr @snide, I would like to take up the issue. Shall I change the PropType to any instead of String?

@snide
Copy link
Contributor

snide commented Dec 4, 2020

I would change it to a react node rather than any. Go ahead!

@Dishebh Dishebh mentioned this issue Dec 4, 2020
Merged
10 tasks
@Dishebh
Copy link
Contributor

Dishebh commented Dec 4, 2020

@snide opened a PR with the suggested change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[EuiTreeView] [EuiTreeViewNode] changed label PropType in tree_view to ReactNode Dishebh/eui
3 participants
@snide @Dishebh @prcdpr