Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiMarkdownEditor] Add ability to unregister standard plugins (tooltip) #4239

Closed
timroes opened this issue Nov 9, 2020 · 5 comments
Closed

Comments

@timroes
Copy link
Contributor

timroes commented Nov 9, 2020

The EuiMarkdownEditor has currently no possibility to unregister the initial plugins (i.e. the tooltip plugin atm) when using it. Even passing in an empty array to the uiPlugins property will still cause it to be registered.

The component should let the consumer leave complete choice about what plugins will be used, and allow unregistering also that initial plugins.

@chandlerprall
Copy link
Contributor

This should have been treated the same way parsingPluginList and processingPluginList:

  1. default array exposed through a getter/creator function
  2. accepting an override prop

@K-Kumar-01
Copy link
Contributor

@chandlerprall @timroes
I have tried some code that might be able to solve the issue.
Screenshot
DeepinScreenshot_20201214123438
Here on the console panel, I logged the plugins list and it can be seen that the plugin is not there in one of the two logs
(Not used useEffect so each one is logged 2 times)
I have basically used the idea of passing an extra prop which will ensure to include or not include the plugin as required.
Can I make a PR on the issue?

@chandlerprall
Copy link
Contributor

Can I make a PR on the issue?

Please do!

@K-Kumar-01
Copy link
Contributor

@chandlerprall
I have made a PR
However, it says a contributor agreement. I have signed that but still, it shows that the agreement is not signed.
Can you please explain this and review my PR?

@chandlerprall
Copy link
Contributor

Resolved by #4383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants