Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiInMemoryTable] Replace props_info.js with the new prop loader #4149

Closed
elizabetdev opened this issue Oct 16, 2020 · 1 comment · Fixed by #4179
Closed

[EuiInMemoryTable] Replace props_info.js with the new prop loader #4149

elizabetdev opened this issue Oct 16, 2020 · 1 comment · Fixed by #4179
Assignees
@elizabetdev
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries

Comments

@elizabetdev
Copy link
Contributor

The EuiInMemoryTable is still using a props_info.js file to generate the props table in our docs.

Following the work on #4125, we need to use the new !!prop-loader! to recreate the EuiInMemoryTable props tables. This way, any new prop added to the component will be automatically exposed.
@elizabetdev elizabetdev added documentation Issues or PRs that only affect documentation - will not need changelog entries assign:anyone labels Oct 16, 2020
@elizabetdev elizabetdev mentioned this issue Oct 16, 2020
Merged
5 tasks
@elizabetdev
Copy link
Contributor Author

By replacing the props_info.js with the new !!prop-loader! we might also fix:

@elizabetdev elizabetdev self-assigned this Oct 22, 2020
@elizabetdev elizabetdev mentioned this issue Oct 26, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elizabetdev elizabetdev

Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Docs, EuiInMemoryTable] Recreating props tables elizabetdev/eui
1 participant
@elizabetdev