Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiRangeInput] doesn't show invalid state on change #4082

Closed
mbondyra opened this issue Sep 30, 2020 · 1 comment
Closed

[EuiRangeInput] doesn't show invalid state on change #4082

mbondyra opened this issue Sep 30, 2020 · 1 comment
Labels

Comments

@mbondyra
Copy link
Contributor

EuiRangeInput doesn’t show invalid state (eg. out of the range or defined in isInvalid prop) as long as I have focus, and the red highlighting would only appear once I blur the input. I tried to play with it by passing directly isInvalid prop with condition, but it doesn’t change anything (demo here, applying the value -1 would be the showcase).

image

@mbondyra mbondyra added the bug label Sep 30, 2020
@mbondyra mbondyra changed the title [EuiEuiRangeInputRange] doesn't show invalid state on change [EuiRangeInput] doesn't show invalid state on change Sep 30, 2020
@cchaos
Copy link
Contributor

cchaos commented Sep 30, 2020

Thanks @mbondyra! To quote my slack reply:

This is actually how all of the inputs behave. The focus state will always override invalid. However, I think your concern is valid and can be generalized to all inputs. But it requires more thought on design and implementation so it may be a while before a solution is implemented.

I've moved your comment over to #2017 to group with the discussion for all inputs and I'm going to close this one as it is not a bug, but is as intended but we'll continue to discuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants