Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiButtonIcon] iconType prop should be required #4059

Closed
elizabetdev opened this issue Sep 21, 2020 · 0 comments · Fixed by #4106
Closed

[EuiButtonIcon] iconType prop should be required #4059

elizabetdev opened this issue Sep 21, 2020 · 0 comments · Fixed by #4106
Labels
bug

Comments

@elizabetdev
Copy link
Contributor

While working on a different issue I found that we can create EuiButtonIcon without an icon which results on an empty icon button.

The iconType should be required to avoid these cases and to emphasize that consumers should only use this component with an icon.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[EuiButtonIcon] change iconType prop to required ashikmeerankutty/eui
1 participant
@elizabetdev