Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiSelectableTemplateSitewide] Using searchProps.onSearch breaks search highlighting #4041

Closed
myasonik opened this issue Sep 15, 2020 · 2 comments
Closed

[EuiSelectableTemplateSitewide] Using searchProps.onSearch breaks search highlighting #4041

myasonik opened this issue Sep 15, 2020 · 2 comments
Assignees
@cchaos
Labels
bug

Comments

@myasonik
Copy link
Contributor

onSearch can be passed in to searchProps but then breaks highlighting of search results because the searchValue in EuiSearchField gets set to an empty string for some reason. There's a workaround that consuming apps can use of using onKeyUpCapture instead.

Theis might be a problem more broadly with EuiSelectable but I haven't tested that.
@cchaos cchaos removed the search bar label Sep 19, 2020
@cchaos cchaos self-assigned this Sep 20, 2020
@thompsongl
Copy link
Contributor

thompsongl commented Nov 5, 2020 •
edited
Loading

I think this would be resolved by #4153 (same root cause as #4132), but haven't verified

@thompsongl
Copy link
Contributor

#4153 appears to solve this.
Feel free to re-open if you still see problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cchaos cchaos

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cchaos @thompsongl @myasonik