Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font features not working with Inter served by Google Fonts #3964

Closed
cchaos opened this issue Aug 25, 2020 · 2 comments · Fixed by #5078
Closed

Font features not working with Inter served by Google Fonts #3964

cchaos opened this issue Aug 25, 2020 · 2 comments · Fixed by #5078
Labels

Comments

@cchaos
Copy link
Contributor

cchaos commented Aug 25, 2020

I tested this on the Google Font site and it's not working there which is how I determined that's where the problem is.

It was originally found when trying to use the tnum feature for the values of EuiProgress:

Essentially tabular numbers makes the numbers of a font behave almost like they are a monospace font so that when they are lined up in a column, they align better. Here's a screenshot of how it's supposed to behave with Inter. As I mentioned in the meeting, however, this is not currently working with the Google font. So I'll have to explore that later.

Screen Shot 2020-08-25 at 11 37 42 AM

Originally posted by @cchaos in #3948 (comment)

@timroes
Copy link
Contributor

timroes commented Apr 28, 2021

I just wanted to open an issue, but it feels this issue kind of describes this aroundish, so maybe we can just rename this issue.

I wanted to check if there's a specific reason why we're not using the variable font of Inter, but the "traditional" font? Using the variable font would save bandwidth for downloading all that different weight font files and would also allow us to use more variable font features, e.g. see what was described above. Also all browsers we support are supporting variable fonts. Also it's perfectly progressive enhancable by using the variable font just behind a media query (@supports (font-variation-settings: normal) { .. }, see also https://rsms.me/inter/#usage).

So I wanted to suggest if there are no reasons I am overseeing to use the variable font in EUI by default instead of the traditional one.

cc @chandlerprall what I've mentioned recently.

@cchaos
Copy link
Contributor Author

cchaos commented May 25, 2021

The reason we have not use the variable font is because we only recently dropped support for IE (11). It's certainly something we can revisit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants