Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiComboBox] Add the loading spinner to input when isLoading #3852

Closed
shahzad31 opened this issue Aug 3, 2020 · 1 comment · Fixed by #4015
Closed

[EuiComboBox] Add the loading spinner to input when isLoading #3852

shahzad31 opened this issue Aug 3, 2020 · 1 comment · Fixed by #4015

Comments

@shahzad31
Copy link
Contributor

EuiComboxbox isLoading state is broken, when props isLoading is set to true, it doesn't do anything.

image

@cchaos
Copy link
Contributor

cchaos commented Aug 3, 2020

The loading state is not actually broken. The current implementation of that component's loading state just replaces the dropdown contents with a loading indicator, so you have to actually open the combo box to see the loading state.

Screen Shot 2020-08-03 at 15 06 06 PM

However, we could additionally add the loading spinner to the input as well similar to how the other inputs handle it.

@cchaos cchaos changed the title Combo box loading is broken [EuiComboBox] Add the loading spinner to input when isLoading Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants