Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiComboBox] Allow explicit id to track selected item #3803

Closed
timroes opened this issue Jul 27, 2020 · 1 comment · Fixed by #4048
Closed

[EuiComboBox] Allow explicit id to track selected item #3803

timroes opened this issue Jul 27, 2020 · 1 comment · Fixed by #4048
Labels
feature request good first issue

Comments

@timroes
Copy link
Contributor

timroes commented Jul 27, 2020

Currently the EuiComboBox uses the label of an item as key in React and to keep track whether it's marked or not. It should also allow specifying an explicit id in case there might be duplicate label within the options. Obviously it won't be good usability to have multiple times the same label, but in some cases we allow the user to specify the label and cannot (easily) prevent duplicate labels (while still having separate underlaying) values in the options.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[EuiComboBox] Allow options to have a unique key timroes/eui
3 participants
@cchaos @timroes @thompsongl