Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiFocusTrap] doesn't pass style props to div #3795

Closed
phyolim opened this issue Jul 23, 2020 · 4 comments · Fixed by #3916
Closed

[EuiFocusTrap] doesn't pass style props to div #3795

phyolim opened this issue Jul 23, 2020 · 4 comments · Fixed by #3916
Labels
bug

Comments

@phyolim
Copy link
Contributor

phyolim commented Jul 23, 2020 •
edited
Loading

Previously, when style props are passed into EuiFocusTrap, they would be applied to the <div data-focus-lock-disabled>
I noticed it no longer get applied to this div on 27.2.0.
@thompsongl
Copy link
Contributor

Thanks, @phylim

We changed the underlying library for focus trapping and this appears to be an API gap. Should be resolvable.

@thompsongl thompsongl added the bug label Jul 27, 2020
@phyolim
Copy link
Contributor Author

phyolim commented Jul 30, 2020 •
edited
Loading

I saw that.. It is still passing the style props through to <FocusOn>. Looks like FocusOn doesn't accept it..

As a workaround I'm overwriting styles with styled-components for now.

@thompsongl
Copy link
Contributor

👉 theKashey/react-focus-on#46

@thompsongl
Copy link
Contributor

Fix coming for this in a new version of react-focus-on hopefully this week.

@thompsongl thompsongl mentioned this issue Aug 13, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[EuiFocusTrap] accept style prop thompsongl/eui
2 participants
@thompsongl @phyolim