Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiComboBox shows scrollbars since update to 27.0.0 #3736

Closed
timroes opened this issue Jul 14, 2020 · 1 comment · Fixed by #3744
Closed

EuiComboBox shows scrollbars since update to 27.0.0 #3736

timroes opened this issue Jul 14, 2020 · 1 comment · Fixed by #3744

Comments

@timroes
Copy link
Contributor

timroes commented Jul 14, 2020

After the update from EUI 26.3.0 to 27.0.0 the EuiComboBox component started showing always scrollbars (no matter the amount of elements) and is for a few pixels scrollable, since the content slightly extends the container always (the following combobox has only 3 elements):

screenshot-20200714-111925

@chandlerprall
Copy link
Contributor

chandlerprall commented Jul 14, 2020

Confirmed the issue in Chrome, Firefox, and Edge on MacOS. Issue comes from EuiComboBoxOptionsList's default value for rowHeight, looks like it needs to be changed to 29 instead of its current 27 - this change removes the scrollbar in the 3 mentioned browsers. Looks like the switch from react-virtualized to react-window caused some small pixel shifting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants