Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EuiCode TS interface to reflect used/unused props #3612

Closed
thompsongl opened this issue Jun 15, 2020 · 4 comments · Fixed by #3647
Closed

Update EuiCode TS interface to reflect used/unused props #3612

thompsongl opened this issue Jun 15, 2020 · 4 comments · Fixed by #3647

Comments

@thompsongl
Copy link
Contributor

But on changing paddingSize or fontSize no change is observed in EuiCode but the EuiCodeBlock works fine. I tried setting paddingSize in codeSandBox also no change is observed for EuiCode

EuiCode does not really accept paddingSize or fontSize. The props interfaces for EuiCode and EuiCodeBlock should be updated to reflect what props will have functional impact.

Originally posted by @thompsongl in #3529 (comment)

@shrey
Copy link
Contributor

shrey commented Jun 23, 2020

@thompsongl How would you want the EuiCode to be updated i.e should I just delete the unused props?

@thompsongl
Copy link
Contributor Author

should I just delete the unused props?

Omit-ing the unused props is likely to solve the problem, yes

@shrey
Copy link
Contributor

shrey commented Jun 23, 2020

@thompsongl Is overflowHeight a valid prop for EuiCode or just for EuiCodeBlock ?

@snide
Copy link
Contributor

snide commented Jun 23, 2020

@shrey overflowHeight is only used for EuiCodeBlock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants