Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add EuiCard display prop example #3552

Closed
cchaos opened this issue Jun 4, 2020 · 3 comments · Fixed by #3638
Closed

[Docs] Add EuiCard display prop example #3552

cchaos opened this issue Jun 4, 2020 · 3 comments · Fixed by #3638
Assignees

Comments

@cchaos
Copy link
Contributor

cchaos commented Jun 4, 2020

We might need to add an option in EUI to render EuiCard without the panel (border & shadow) display.

Originally posted by @cchaos in elastic/kibana#67467

Screen Shot 2020-06-04 at 12 14 18 PM

This also occurs on the Kibana homepage with overriding styles, but would be good to have a consistent approach supplied by EUI. Though if the cards are clickable, they should still have the shadow appearance on hover/focus.

Screen Shot 2020-06-04 at 12 15 13 PM

@snide
Copy link
Contributor

snide commented Jun 4, 2020

Reminder for whoever picks this up that this one might touch amsterdam files.

@cauemarcondes
Copy link

cauemarcondes commented Jun 5, 2020

@cchaos elastic/kibana#67467 (comment)

But it'd be very good a padding property.

@cchaos
Copy link
Contributor Author

cchaos commented Jun 5, 2020

^^ @andreadelrio, I forgot we actually have this option already with display. (Doh!) We may still want to add a docs example for it though and look into the padding request.

@cchaos cchaos changed the title Allow EuiCard to render without the panel (border & shadow) display [Docs] Allow EuiCard display prop example Jun 5, 2020
@cchaos cchaos changed the title [Docs] Allow EuiCard display prop example [Docs] Add EuiCard display prop example Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants