Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] Document what props cause rows to re-render #3518

Closed
chandlerprall opened this issue May 27, 2020 · 2 comments
Closed

[EuiDataGrid] Document what props cause rows to re-render #3518

chandlerprall opened this issue May 27, 2020 · 2 comments
Labels
data grid documentation Issues or PRs that only affect documentation - will not need changelog entries stale-issue stale-issue-closed

Comments

@chandlerprall
Copy link
Contributor

chandlerprall commented May 27, 2020

There are quite a few props which could cause EuiDataGrid to re-render all of the rows (and if inMemory is enabled this would be all rows, not only paginated/visible ones). Most are probably not obvious, and debugging which one is causing a performance issue is tedious. These should be documented.

This list is affected by the in-progress virtualization #4170

The internal rows representation is recomputed if these change (struck out items are internal-only and should be more limited in scope),
rowCount,
columns,
inMemory.skipColumns,
renderCellValue,
onCellRender,
visibleRowIndices,
rowMap,
leadingControlColumns,
trailingControlColumns,
columns,
schema,
popoverContents,
columnWidths,
defaultColumnWidth,
focusedCell,
onCellFocus,
interactiveCellId,

The impact of each should be evaluated and documented.

@chandlerprall chandlerprall added documentation Issues or PRs that only affect documentation - will not need changelog entries data grid labels May 27, 2020
@cchaos cchaos changed the title Document what props cause EuiDataGrid rows to re-render [EuiDataGrid] Document what props cause rows to re-render Sep 20, 2020
@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

❌ We're automatically closing this issue due to lack of activity. Please comment if you feel this was done in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data grid documentation Issues or PRs that only affect documentation - will not need changelog entries stale-issue stale-issue-closed
Projects
None yet
Development

No branches or pull requests

1 participant