Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import is not done in correct manner #3040

Closed
anishagg17 opened this issue Mar 10, 2020 · 4 comments · Fixed by #3043
Closed

Import is not done in correct manner #3040

anishagg17 opened this issue Mar 10, 2020 · 4 comments · Fixed by #3043

Comments

@anishagg17
Copy link
Contributor

Screenshot 2020-03-11 at 4 00 26 AM

@thompsongl is the highlighted import done in correct way?

or should it be

import { VISUALIZATION_COLORS } from '@elastic/services'
@snide
Copy link
Contributor

snide commented Mar 11, 2020

Likely this should be replaced and import from one of the palette services that EUI now outputs.

import {
  euiPaletteColorBlind,
} from '@elastic/eui/lib/services';

https://elastic.github.io/eui/#/utilities/color-palettes

@anishagg17 anishagg17 mentioned this issue Mar 11, 2020
Merged
2 tasks
@anishagg17
Copy link
Contributor Author

Screenshot 2020-03-11 at 3 53 15 PM

@snide is there any services related to display toggles also??

@cchaos
Copy link
Contributor

cchaos commented Mar 11, 2020

No, DisplayToggles only exist in docs

@anishagg17
Copy link
Contributor Author

Okay @cchaos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed some imports anishagg17/eui
3 participants
@snide @cchaos @anishagg17