-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discuss] isColorDark documentation #2945
Comments
Is this in JS or SASS? |
Think the JS. They are essentially part of our services folder. We could document them, but my guess is that with our moves towards Chroma or Polished, we'll end up deprecating these functions. I know @thompsongl was thinking along these lines somewhere (can't find the issue) |
I should have included the link 😊: |
Right, #2804 gets at this. I think all new color manipulation should use chroma-js, and we're already fairly close to being able to remove the custom utilities |
OK. Gonna close this out then, thinking that having these somewhat hidden for the moment makes sense. |
Yesterday, while using the EUI utility
isColorDark
I had to transform hex colors to rbg because this utility only accepts rgb.I created my own function and then I realized that EUI has an
hexToRgb
utility and even other color utilities. I believe they are not documented. I found them searching through the codebase.Should we improve the
isColorDark
docs section with more examples? With one that uses the EUIhexToRgb
function?Or should we have a color section under utilities where
isColorDark
would be included among other color utilities?The text was updated successfully, but these errors were encountered: