Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discuss] Compressed input contrast #2564

Closed
ryankeairns opened this issue Nov 26, 2019 · 1 comment · Fixed by #2568
Closed

[Discuss] Compressed input contrast #2564

ryankeairns opened this issue Nov 26, 2019 · 1 comment · Fixed by #2568

Comments

@ryankeairns
Copy link
Contributor

Canvas has switched to using the compressed inputs, however it also employs a non-white background color. The current compressed button group input (maybe others?) use a transparent/non-filled background that allows the background color to show through.

In the case of Canvas, this is problematic as the background color is very similar to the active state of the buttons in the button group. I've titled this issue as a 'Discuss' tops since we could override styles in Canvas. On the other hand, we could explore alternative default styles, for example, using the same bg color as text inputs.

image

@cchaos
Copy link
Contributor

cchaos commented Nov 26, 2019

I completely agree and was actually just noticing that today as well. I'm good with it 👍 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants