-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The fourth color in the color blind viz palette does not work in dark mode #2238
Comments
I've been messing around with the visualization color palette using 3 different tools.
I started with our original palette and plugged it into [1] which gave me back a slightly better stepping of colors. These ten colors I then put into [2] which told me I wasn't completely color-blind safe, so I adjusted individual colors until I got safe across the board. P.S. our current palette isn't actually fully safe, it fails the trit test. Edit: The links to the tools referenced above are not working because it's changing special characters, copy/paste the links from below [1] https://leonardocolor.io/?colorKeys=%2300b3a4%2C%233185fc%2C%23db1374%2C%23490092%2C%23feb6db%2C%23e6c220%2C%23bfa180%2C%23f98510%2C%23461a0a%2C%23920000&base=ffffff&ratios=1.6%2C1.78%2C2.21%2C2.78%2C3.50%2C4.40%2C5.48%2C6.77%2C8.29%2C11.16&mode=CAM02 The final palette
It's not a major departure from our current palette (on purpose) but we do have to decide if we want to re-order the palette to be more sequential. TextThe issues we still have are with text but we're no worse off than we were before. I think it just means that we shouldn't be using these colors for the text itself but more like badge colors where we can control the text contrast (isItLightOrDark) like it shows in the Chroma.js helper: |
@VijayDoshi would probably be interested in tracking this. Complaints that we've got on the palette is that it is very saturated and "hot". Might be an opportunity for us to lower the lights a bit if we're messing with this stuff anyway. My vote would be to keep the same ordering as before if possible, if for no other reason then I can't see Kibana with pink charts by default. It would be nice if they started by matching our branding and the UI around it, but that's just an opinion. |
The new color set is already less saturated than the current set, do you think this needs to change even more? |
Was looking at this again this evening, I do like the direction! It feels much more balanced. We'd probably need to get others involved in getting to a decision on a new default pallet. Do we need to consider a similar treatment for gradients? |
@VijayDoshi Who do you include in 'others'? I have socialized this a few times to the other designers within the org including CS. I am working adjusting the current and creating more quantitative palettes to match these colors. However, single color palettes tend to need more extremes in order to create more distinguishable steps and so these tend to be slightly more saturated at the ends, though I tried to use the same colors from the color blind palette. I should have a PR up sometime this week that anyone can review. |
The PR is up here: #2686 |
There was mention that breaking a few of the colors to be completely different from their original value may not be idea. So here is a palette option that keeps the same "value". cc @formgeist |
@cchaos I really like this updated palette that keeps the same range as the previous |
Posting @VijayDoshi's comment surrounding the saturation issue.
|
While I agree that there were some hot (saturated) colors in the original set, they also happened to be the first 3-4 colors which means they were used most predominantly. Given that, my caution here is that we don't tone down (desaturate) too much across the board if there were really only a few culprits. |
After thinking about it during my drive to ATL, I'd have to agree with @ryankeairns. I don't think modifying all the colors is necessary. I'd personally love to know a little more about where the term "hot colors" originated from and get some more context around that piece of feedback. |
It's due to some degree to some lazy handling of the default graphs. As an example. These are live views in the Metrics app. Which come from default values being passed from Elastic Charts When @formgeist uses the palette within APM, he's often using opacity on top of the coloring, which naturally mutes them. Obvioiusly there is much more at play than just the coloring. In many cases, engineering needs to be more considerate in how they present these charts. But if our aim is to solve accessibility it's likely complicated. My guess is that opacity has some factor in this stuff. |
@johnbarrierwilson There is a ton of research on color contrast. My observation is regarding something called "extension contrast" and "Simultaneity of color." When you place highly saturated opposing colors they appear to "vibrate" - this distraction can lead to over-weighting the involved colors and over time (imagine a SOC dashboard) fatigue. Look at the following two and compare how much more you focus on the bottom three segments of the one on the right; whereas, your brain gives more equal weight to the ones on the left (at least mine does) This is a good article that provides some context for how impactful the pallet can be and some foundational concepts of color theory - this is a really deep topic though. Here is an excerpt/example:
|
That's a fantastic summary and research article. Thanks for sharing @VijayDoshi! |
It's really the only color that has this issue. Is there any kind of quick tweak we can do to make it better? This tool might be helpful in finding another color.
The text was updated successfully, but these errors were encountered: