Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text should never flow under combo box icons #2126

Closed
jasonrhodes opened this issue Jul 16, 2019 · 1 comment · Fixed by #2135
Closed

Text should never flow under combo box icons #2126

jasonrhodes opened this issue Jul 16, 2019 · 1 comment · Fixed by #2135
Assignees
Labels

Comments

@jasonrhodes
Copy link
Member

In this example of the EuiComboBox in use, a long value can flow underneath the select arrow and the clearable x icon:

Screen Shot 2019-07-15 at 11 04 14 PM

Adding 55px of right padding to the .euiComboBox__inputWrap div happens to solve this particular instance of the problem:

Screen Shot 2019-07-15 at 11 03 46 PM

But obviously that's a terrible hard-coded solution that probably doesn't work everywhere. Can we solve this so that the icons never allow anything to flow underneath inside the ComboBox input?

@cchaos
Copy link
Contributor

cchaos commented Jul 16, 2019

I noticed this too and I'm not sure when it broke. However, I've got a fix coming, I just need to separate it from my compressed forms work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants