Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change EuiCallout danger example from using X (cross) as icon #2024

Closed
cchaos opened this issue Jun 10, 2019 · 1 comment · Fixed by #2036
Closed

Change EuiCallout danger example from using X (cross) as icon #2024

cchaos opened this issue Jun 10, 2019 · 1 comment · Fixed by #2036
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries good first issue

Comments

@cchaos
Copy link
Contributor

cchaos commented Jun 10, 2019

We use the cross icon to indicate "close" in flyouts, modals and toasts. They shouldn't also indicate errors. I see a lot of copy pasting of this example in Kibana. We need to change it in our docs.
@cchaos cchaos added documentation Issues or PRs that only affect documentation - will not need changelog entries assign:anyone good first issue labels Jun 10, 2019
@snide
Copy link
Contributor

snide commented Jun 11, 2019

Leave this one around. It's nice and small and I'll use it at some point as walkthrough of our PR process with @mdefazio.

@snide snide mentioned this issue Jun 12, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change callout docs to using alert icon, aws logo updated for dark mode snide/eui
2 participants
@snide @cchaos