Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiBadge contrast accessibility #1894

Closed
cjcenizal opened this issue Apr 29, 2019 · 2 comments · Fixed by #2455
Closed

EuiBadge contrast accessibility #1894

cjcenizal opened this issue Apr 29, 2019 · 2 comments · Fixed by #2455

Comments

@cjcenizal
Copy link
Contributor

I noticed that badge colors seem to have darkened. I understand if the color contrast algorithm marks these as meeting the AA accessibility contrast ratio:

image

However, as a human trying to read these, I struggle. Would you mind doing a quick straw poll to see if anyone else also has a hard time? If others have a hard time too, is it possible to use the lighter colors, which I believe also had a passing color ratio? Here they are for reference:

image

@cchaos
Copy link
Contributor

cchaos commented Apr 29, 2019

I agree that the badge colors have become harder to read and a bit muted. I think we need to tinker a bit more with getting these values to be on the brighter side not only for readability but also the distinction between these two in particular are hard to tell.

@snide I remember you were tinkering with these a while back. Was that when the dark mode colors were altered?

@snide
Copy link
Contributor

snide commented Apr 29, 2019

Likely. We can probably do a more math based approach to these then the hand-wavy calcs in there now. I agree they are soft, so thanks for bringing it up.

Probably we can use the highcontrast mixin given the known quantity of the text colors. I can take this on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants