Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter group options should retain order, regardless of selection state #1371

Closed
cjcenizal opened this issue Dec 13, 2018 · 4 comments · Fixed by #3063
Closed

Filter group options should retain order, regardless of selection state #1371

cjcenizal opened this issue Dec 13, 2018 · 4 comments · Fixed by #3063

Comments

@cjcenizal
Copy link
Contributor

This came up during our review of ILM. Many participants were surprised by the reordering of the options when they were de/selected:

filter-group-option-order

As a user, if I misclick I want to be able to click again to correct my misclick, but the reordering of the options makes this an exercise in frustration, because it just results in another misclick. If I've scrolled down in the list, then it looks like the option I clicked disappeared, which is also confusing.

GitHub's UI has a nice UX:

static-position

What's particularly nice is that the selected items are moved to the top after the user has finished making their selection and closed the list:

image

@snide
Copy link
Contributor

snide commented Dec 13, 2018

Heh, we originally copied GH for this. They changed it :D We can do it again! I think it's nice to have them at top when you reopen, which we should mimic.

@cchaos cchaos self-assigned this Feb 13, 2019
@cchaos cchaos removed their assignment Oct 21, 2019
@anishagg17
Copy link
Contributor

@snide I want to reproduce this issue in docs but I didn't find any relevant example should I add such to docs?

@snide
Copy link
Contributor

snide commented Mar 12, 2020

You can see this on the search bar example for tags. https://elastic.github.io/eui/#/forms/search-bar

Note how they move to the top on press. As @cjcenizal mentions. it would be preferable if they retained their position while the popup was open, but then listed them at top if later re-opened.

@anishagg17
Copy link
Contributor

OKay thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants