From 981914eb812fc528932f5d440e508a5ecebafecf Mon Sep 17 00:00:00 2001
From: Anish Aggarwal <43617894+anishagg17@users.noreply.github.com>
Date: Mon, 24 Feb 2020 22:26:02 +0530
Subject: [PATCH] Fixes #2217  : removed duplicate icons (#2908)

* removed duplicate icons

* Fixing changelog and updating tests (#1)

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
---
 CHANGELOG.md                                  |  4 +++
 src-docs/src/views/icon/icons.js              |  2 --
 .../icon/__snapshots__/icon.test.tsx.snap     | 34 -------------------
 src/components/icon/assets/vis_controls.js    | 16 ---------
 src/components/icon/assets/vis_controls.svg   |  3 --
 src/components/icon/assets/vis_heatmap.js     | 16 ---------
 src/components/icon/assets/vis_heatmap.svg    |  3 --
 src/components/icon/icon.tsx                  |  2 --
 8 files changed, 4 insertions(+), 76 deletions(-)
 delete mode 100644 src/components/icon/assets/vis_controls.js
 delete mode 100644 src/components/icon/assets/vis_controls.svg
 delete mode 100644 src/components/icon/assets/vis_heatmap.js
 delete mode 100644 src/components/icon/assets/vis_heatmap.svg

diff --git a/CHANGELOG.md b/CHANGELOG.md
index f70d2e2ce79..b8e5fa4dbd4 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -18,6 +18,10 @@
 - Fixed building dev & docs on Windows ([#2847](https://github.com/elastic/eui/pull/2847))
 - Fixed a bug in `EuiDataGrid` causing the first cell to autofocus if interactive ([#2872](https://github.com/elastic/eui/pull/2872))
 
+**Breaking changes**
+
+- Removed `visControls` and `visHeatmap` duplicate icons from docs ([#2908](https://github.com/elastic/eui/pull/2908))
+
 ## [`19.0.0`](https://github.com/elastic/eui/tree/v19.0.0)
 
 - Added `cheer` glyph to `EuiIcon` ([#2814](https://github.com/elastic/eui/pull/2814))
diff --git a/src-docs/src/views/icon/icons.js b/src-docs/src/views/icon/icons.js
index de9f2b8f637..a462c769bf7 100644
--- a/src-docs/src/views/icon/icons.js
+++ b/src-docs/src/views/icon/icons.js
@@ -201,10 +201,8 @@ export const iconTypes = [
   'visBarHorizontalStacked',
   'visBarVertical',
   'visBarVerticalStacked',
-  'visControls',
   'visGauge',
   'visGoal',
-  'visHeatmap',
   'visLine',
   'visMapCoordinate',
   'visMapRegion',
diff --git a/src/components/icon/__snapshots__/icon.test.tsx.snap b/src/components/icon/__snapshots__/icon.test.tsx.snap
index f60a8d6b9c8..01f39c8c6d5 100644
--- a/src/components/icon/__snapshots__/icon.test.tsx.snap
+++ b/src/components/icon/__snapshots__/icon.test.tsx.snap
@@ -8239,23 +8239,6 @@ exports[`EuiIcon props type visBarVerticalStacked is rendered 1`] = `
 </svg>
 `;
 
-exports[`EuiIcon props type visControls is rendered 1`] = `
-<svg
-  aria-hidden="true"
-  class="euiIcon euiIcon--medium euiIcon-isLoaded"
-  focusable="false"
-  height="16"
-  role="img"
-  viewBox="0 0 16 16"
-  width="16"
-  xmlns="http://www.w3.org/2000/svg"
->
-  <path
-    d="M8.05 10a2.5 2.5 0 014.9 0H15v1h-2.05a2.5 2.5 0 01-4.9 0H1v-1h7.05zm-.1-4a2.5 2.5 0 01-4.9 0H1V5h2.05a2.5 2.5 0 014.9 0H15v1H7.95zM4 5.5a1.5 1.5 0 103 0 1.5 1.5 0 00-3 0zm8 5a1.5 1.5 0 10-3 0 1.5 1.5 0 003 0z"
-  />
-</svg>
-`;
-
 exports[`EuiIcon props type visGauge is rendered 1`] = `
 <svg
   aria-hidden="true"
@@ -8290,23 +8273,6 @@ exports[`EuiIcon props type visGoal is rendered 1`] = `
 </svg>
 `;
 
-exports[`EuiIcon props type visHeatmap is rendered 1`] = `
-<svg
-  aria-hidden="true"
-  class="euiIcon euiIcon--medium euiIcon-isLoaded"
-  focusable="false"
-  height="16"
-  role="img"
-  viewBox="0 0 16 16"
-  width="16"
-  xmlns="http://www.w3.org/2000/svg"
->
-  <path
-    d="M12 9a3 3 0 110 6 3 3 0 010-6zm0 1a2 2 0 100 4 2 2 0 000-4zM4 2a2 2 0 110 4 2 2 0 010-4zm0 1a1 1 0 100 2 1 1 0 000-2zm0 5a4 4 0 110 8 4 4 0 010-8zm0 1a3 3 0 100 6 3 3 0 000-6zm8-9a4 4 0 110 8 4 4 0 010-8zm0 1a3 3 0 100 6 3 3 0 000-6z"
-  />
-</svg>
-`;
-
 exports[`EuiIcon props type visLine is rendered 1`] = `
 <svg
   aria-hidden="true"
diff --git a/src/components/icon/assets/vis_controls.js b/src/components/icon/assets/vis_controls.js
deleted file mode 100644
index fd1fb729de2..00000000000
--- a/src/components/icon/assets/vis_controls.js
+++ /dev/null
@@ -1,16 +0,0 @@
-import React from 'react';
-
-const EuiIconVisControls = ({ title, titleId, ...props }) => (
-  <svg
-    width={16}
-    height={16}
-    viewBox="0 0 16 16"
-    xmlns="http://www.w3.org/2000/svg"
-    aria-labelledby={titleId}
-    {...props}>
-    {title ? <title id={titleId}>{title}</title> : null}
-    <path d="M8.05 10a2.5 2.5 0 014.9 0H15v1h-2.05a2.5 2.5 0 01-4.9 0H1v-1h7.05zm-.1-4a2.5 2.5 0 01-4.9 0H1V5h2.05a2.5 2.5 0 014.9 0H15v1H7.95zM4 5.5a1.5 1.5 0 103 0 1.5 1.5 0 00-3 0zm8 5a1.5 1.5 0 10-3 0 1.5 1.5 0 003 0z" />
-  </svg>
-);
-
-export const icon = EuiIconVisControls;
diff --git a/src/components/icon/assets/vis_controls.svg b/src/components/icon/assets/vis_controls.svg
deleted file mode 100644
index 18f18120026..00000000000
--- a/src/components/icon/assets/vis_controls.svg
+++ /dev/null
@@ -1,3 +0,0 @@
-<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="16" height="16" viewBox="0 0 16 16">
-  <path transform="rotate(90 8 8)" d="M10,7.94999094 C8.85887984,7.71835578 8,6.70947896 8,5.5 C8,4.29052104 8.85887984,3.28164422 10,3.05000906 L10,1 L11,1 L11,3.05000906 C12.1411202,3.28164422 13,4.29052104 13,5.5 C13,6.70947896 12.1411202,7.71835578 11,7.94999094 L11,15 L10,15 L10,7.94999094 Z M6,8.05000906 C7.14112016,8.28164422 8,9.29052104 8,10.5 C8,11.709479 7.14112016,12.7183558 6,12.9499909 L6,15 L5,15 L5,12.9499909 C3.85887984,12.7183558 3,11.709479 3,10.5 C3,9.29052104 3.85887984,8.28164422 5,8.05000906 L5,1 L6,1 L6,8.05000906 L6,8.05000906 Z M5.5,12 C6.32842712,12 7,11.3284271 7,10.5 C7,9.67157288 6.32842712,9 5.5,9 C4.67157288,9 4,9.67157288 4,10.5 C4,11.3284271 4.67157288,12 5.5,12 Z M10.5,4 C9.67157288,4 9,4.67157288 9,5.5 C9,6.32842712 9.67157288,7 10.5,7 C11.3284271,7 12,6.32842712 12,5.5 C12,4.67157288 11.3284271,4 10.5,4 Z" />
-</svg>
diff --git a/src/components/icon/assets/vis_heatmap.js b/src/components/icon/assets/vis_heatmap.js
deleted file mode 100644
index 8529966aab6..00000000000
--- a/src/components/icon/assets/vis_heatmap.js
+++ /dev/null
@@ -1,16 +0,0 @@
-import React from 'react';
-
-const EuiIconVisHeatmap = ({ title, titleId, ...props }) => (
-  <svg
-    width={16}
-    height={16}
-    viewBox="0 0 16 16"
-    xmlns="http://www.w3.org/2000/svg"
-    aria-labelledby={titleId}
-    {...props}>
-    {title ? <title id={titleId}>{title}</title> : null}
-    <path d="M12 9a3 3 0 110 6 3 3 0 010-6zm0 1a2 2 0 100 4 2 2 0 000-4zM4 2a2 2 0 110 4 2 2 0 010-4zm0 1a1 1 0 100 2 1 1 0 000-2zm0 5a4 4 0 110 8 4 4 0 010-8zm0 1a3 3 0 100 6 3 3 0 000-6zm8-9a4 4 0 110 8 4 4 0 010-8zm0 1a3 3 0 100 6 3 3 0 000-6z" />
-  </svg>
-);
-
-export const icon = EuiIconVisHeatmap;
diff --git a/src/components/icon/assets/vis_heatmap.svg b/src/components/icon/assets/vis_heatmap.svg
deleted file mode 100644
index b0e7604ca47..00000000000
--- a/src/components/icon/assets/vis_heatmap.svg
+++ /dev/null
@@ -1,3 +0,0 @@
-<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="0 0 16 16">
-  <path d="M12,9 C13.6568542,9 15,10.3431458 15,12 C15,13.6568542 13.6568542,15 12,15 C10.3431458,15 9,13.6568542 9,12 C9,10.3431458 10.3431458,9 12,9 Z M12,10 C10.8954305,10 10,10.8954305 10,12 C10,13.1045695 10.8954305,14 12,14 C13.1045695,14 14,13.1045695 14,12 C14,10.8954305 13.1045695,10 12,10 Z M4,2 C5.1045695,2 6,2.8954305 6,4 C6,5.1045695 5.1045695,6 4,6 C2.8954305,6 2,5.1045695 2,4 C2,2.8954305 2.8954305,2 4,2 Z M4,3 C3.44771525,3 3,3.44771525 3,4 C3,4.55228475 3.44771525,5 4,5 C4.55228475,5 5,4.55228475 5,4 C5,3.44771525 4.55228475,3 4,3 Z M4,8 C6.209139,8 8,9.790861 8,12 C8,14.209139 6.209139,16 4,16 C1.790861,16 -8.8817842e-16,14.209139 -8.8817842e-16,12 C-8.8817842e-16,9.790861 1.790861,8 4,8 Z M4,9 C2.34314575,9 1,10.3431458 1,12 C1,13.6568542 2.34314575,15 4,15 C5.65685425,15 7,13.6568542 7,12 C7,10.3431458 5.65685425,9 4,9 Z M12,0 C14.209139,0 16,1.790861 16,4 C16,6.209139 14.209139,8 12,8 C9.790861,8 8,6.209139 8,4 C8,1.790861 9.790861,0 12,0 Z M12,1 C10.3431458,1 9,2.34314575 9,4 C9,5.65685425 10.3431458,7 12,7 C13.6568542,7 15,5.65685425 15,4 C15,2.34314575 13.6568542,1 12,1 Z"/>
-</svg>
diff --git a/src/components/icon/icon.tsx b/src/components/icon/icon.tsx
index 82b4359a013..268fa426d80 100644
--- a/src/components/icon/icon.tsx
+++ b/src/components/icon/icon.tsx
@@ -333,10 +333,8 @@ const typeToPathMap = {
   visBarHorizontalStacked: 'vis_bar_horizontal_stacked',
   visBarVertical: 'vis_bar_vertical',
   visBarVerticalStacked: 'vis_bar_vertical_stacked',
-  visControls: 'vis_controls',
   visGauge: 'vis_gauge',
   visGoal: 'vis_goal',
-  visHeatmap: 'vis_heatmap',
   visLine: 'vis_line',
   visMapCoordinate: 'vis_map_coordinate',
   visMapRegion: 'vis_map_region',