From 19961cd2ade1d9d1c04c8e76a652f65a9e075c38 Mon Sep 17 00:00:00 2001 From: Yuri Astrakhan Date: Tue, 18 Aug 2020 15:24:35 -0400 Subject: [PATCH 1/2] [EuiBasicTable] Fix limited expandable row height (#3855) In some cases max-height of a sub-row needs to be more than 1000px. Thanks to all the great help from @cchaos , unsetting `max-height` after 99% animation is done looks good. The 99% is limited to 100vh. Note that setting `max-height: max-content` breaks in Safari, so cannot be used. --- CHANGELOG.md | 5 +++++ src/components/table/_table.scss | 6 +++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 23b17686b7b..1f81caff8af 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,11 @@ No public interface changes since `28.1.0`. + +**Bug fixes** + +- Fixed bug in `EuiBasicTable` not fully expanding tall rows (height > 1000px) ([#3855](https://github.com/elastic/eui/pull/3855)) + ## [`28.1.0`](https://github.com/elastic/eui/tree/v28.1.0) - Added `isLoading` and `isLoadingMessage` props to `EuiAccordion` ([#3879](https://github.com/elastic/eui/pull/3879)) diff --git a/src/components/table/_table.scss b/src/components/table/_table.scss index 4168f41946f..0e7405fb66a 100644 --- a/src/components/table/_table.scss +++ b/src/components/table/_table.scss @@ -226,8 +226,12 @@ max-height: 0; } + 99% { + max-height: 100vh; + } + 100% { - max-height: 1000px; + max-height: unset; } } From 15df79182737197df7afd39ab24ca2fcfe237194 Mon Sep 17 00:00:00 2001 From: Jeff Astor Date: Tue, 18 Aug 2020 13:20:34 -0700 Subject: [PATCH 2/2] [Docs] Updated form guidelines with friendly spellcheck (#3937) --- src-docs/src/views/form_layouts/guidelines.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src-docs/src/views/form_layouts/guidelines.js b/src-docs/src/views/form_layouts/guidelines.js index b317255ec95..8fc59aad61d 100644 --- a/src-docs/src/views/form_layouts/guidelines.js +++ b/src-docs/src/views/form_layouts/guidelines.js @@ -56,7 +56,7 @@ export default () => (

Provide help text

Show validation parameters in the help text below the input. For - example: Spaces and special charaters are not allowed. + example: Spaces and special characters are not allowed.