Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow my_app_name to be configurable #17

Closed
nickpeihl opened this issue Jan 29, 2020 · 0 comments · Fixed by #18
Closed

Allow my_app_name to be configurable #17

nickpeihl opened this issue Jan 29, 2020 · 0 comments · Fixed by #18

Comments

@nickpeihl
Copy link
Member

ems-client/src/ems_client.js

Lines 110 to 111 in 9815cd8

my_app_name: 'kibana',
my_app_version: kbnVersion,

The my_app_name parameter is currently hard-coded to "kibana". Since ems-client is also used by ems-landing-page and possibly other apps in the future, we should be able to specify this in the constructor.

Additionally, kbnVersion should probably be renamed to something like appVersion in the constructor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add appName and appVersion parameters nickpeihl/ems-client
1 participant
@nickpeihl