-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tsdb metrics builtin component template #97602
Add tsdb metrics builtin component template #97602
Conversation
Documentation preview: |
Hi @martijnvg, I've created a changelog YAML for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll probably need to update
elasticsearch/test/framework/src/main/java/org/elasticsearch/test/rest/ESRestTestCase.java
Line 1842 in 5ebfdda
case "metrics-settings": |
And add metrics-tsdb-settings
.
Otherwise LGTM
Pinging @elastic/es-analytics-geo (Team:Analytics) |
Pinging @elastic/es-data-management (Team:Data Management) |
@elasticmachine update branch |
@eyalkoren New built in template here. Can you check that it aligns with the naming convention? |
Is there a naming convention already? 🤔 |
Lets align it with the hopefully soon to be reached conclusion in #96267 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Martijn
"template": { | ||
"settings": { | ||
"index": { | ||
"lifecycle": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a reminder to override this in stateless to use data stream lifecycle (assuming this component template will be used in data streams only)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iirc this will be used with data streams.
Fleet is currently hard coded to set
index.codec
tobest_compression
(deflate compression). This is good for most data streams, except for data streams were tsdb is enabled. Ideally Fleet doesn't need to set this setting at all and Elasticsearch's default would be good. But unfortunately this isn't the case. It default todefault
(lz4 - optimised for speed), which in would mean much higher disk space usage. Ideally the default would bedefault
when synthetic source is enabled and otherwisebest_compression.
Changing this now, would mean a breaking change.Instead Fleet like to depend on Elasticsearch's internal component templates. To at least abstract some of the internal details away. The
metrics-settings
is ok for non tsdb, but there is no component template for tsdb metrics. This PR adds this.Relates to elastic/kibana#160288