Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increment StackTemplateRegistry#REGISTRY_VERSION #95715

Merged
merged 2 commits into from
May 3, 2023
Merged

Increment StackTemplateRegistry#REGISTRY_VERSION #95715

merged 2 commits into from
May 3, 2023

Conversation

eyalkoren
Copy link
Contributor

Required due to changes made in stack templates in #95481 and #95329

@eyalkoren
Increment StackTemplateRegistry#REGISTRY_VERSION
533c4b5 
Required due to changes made in stack templates in #95481 and #95329
@eyalkoren eyalkoren requested a review from dakrone May 2, 2023 03:55
@elasticsearchmachine elasticsearchmachine added v8.9.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels May 2, 2023
@elasticsearchmachine
Copy link
Collaborator

@eyalkoren please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@pxsalehi pxsalehi added :Data Management/Data streams Data streams and their lifecycles and removed needs:triage Requires assignment of a team area label labels May 2, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label May 2, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

dakrone
dakrone approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@eyalkoren
Copy link
Contributor Author

eyalkoren commented May 3, 2023 •
edited
Loading

What is required, other than passing tests, for merging this one?
I am not sure which label to choose that will not trigger an automatic changelog entry creation. Can we merge without a label?

@dakrone
Copy link
Member

dakrone commented May 3, 2023

I am not sure which label to choose that will not trigger an automatic changelog entry creation. Can we merge without a label?

Normally we would use >non-issue for this, I'll add that label.

@eyalkoren eyalkoren merged commit 842b119 into main May 3, 2023
@eyalkoren eyalkoren deleted the StackTemplateRegistry-version-increment branch May 3, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakrone dakrone dakrone approved these changes

Assignees
No one assigned
Labels
:Data Management/Data streams Data streams and their lifecycles external-contributor Pull request authored by a developer outside the Elasticsearch team >non-issue Team:Data Management Meta label for data/management team v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eyalkoren @elasticsearchmachine @dakrone @pxsalehi