From b8bb8c79bcb7ecb0295a223bae9eda93dfb8bdf4 Mon Sep 17 00:00:00 2001 From: David Turner Date: Mon, 6 Feb 2023 12:08:35 +0000 Subject: [PATCH] More useful toString on UpdateSettingsTask Today `UpdateSettingsTask#toString` is just the default which is not helpful when it appears in logs. This commit makes it include the affected indices and settings. --- .../put/UpdateSettingsClusterStateUpdateRequest.java | 7 +++++++ .../cluster/metadata/MetadataUpdateSettingsService.java | 5 +++++ 2 files changed, 12 insertions(+) diff --git a/server/src/main/java/org/elasticsearch/action/admin/indices/settings/put/UpdateSettingsClusterStateUpdateRequest.java b/server/src/main/java/org/elasticsearch/action/admin/indices/settings/put/UpdateSettingsClusterStateUpdateRequest.java index b8353d5bc970d..f52c659ea55f4 100644 --- a/server/src/main/java/org/elasticsearch/action/admin/indices/settings/put/UpdateSettingsClusterStateUpdateRequest.java +++ b/server/src/main/java/org/elasticsearch/action/admin/indices/settings/put/UpdateSettingsClusterStateUpdateRequest.java @@ -11,6 +11,8 @@ import org.elasticsearch.cluster.ack.IndicesClusterStateUpdateRequest; import org.elasticsearch.common.settings.Settings; +import java.util.Arrays; + /** * Cluster state update request that allows to update settings for some indices */ @@ -51,4 +53,9 @@ public UpdateSettingsClusterStateUpdateRequest settings(Settings settings) { this.settings = settings; return this; } + + @Override + public String toString() { + return Arrays.toString(indices()) + settings; + } } diff --git a/server/src/main/java/org/elasticsearch/cluster/metadata/MetadataUpdateSettingsService.java b/server/src/main/java/org/elasticsearch/cluster/metadata/MetadataUpdateSettingsService.java index d462902d163d9..a85471d04ad75 100644 --- a/server/src/main/java/org/elasticsearch/cluster/metadata/MetadataUpdateSettingsService.java +++ b/server/src/main/java/org/elasticsearch/cluster/metadata/MetadataUpdateSettingsService.java @@ -305,6 +305,11 @@ ClusterState execute(ClusterState currentState) { return updatedState; } + + @Override + public String toString() { + return request.toString(); + } } public void updateSettings(final UpdateSettingsClusterStateUpdateRequest request, final ActionListener listener) {