Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fix deprecated script cache settings #74144

Merged

Conversation

a03nikki
Copy link
Contributor

@a03nikki a03nikki commented Jun 15, 2021

Change

Replace deprecated script.cache.* settings with script.context.$context.cache_* in documentation.

Details

This relates to #50152 and #55038. Starting in 7.9, the breaking change of context specific script cache settings was added. However, the https://www.elastic.co/guide/en/elasticsearch/reference/current/scripts-and-search-speed.html page still references the old setting names.

All scripts are cached by default so that they only need to be recompiled when updates occur. By default, scripts do not have a time-based expiration. You can change this behavior by using the script.cache.expire setting. Use the script.cache.max_size setting to configure the size of the cache.

@a03nikki a03nikki changed the title [DOCS [DOCS] Fix deprecated script cache settings Jun 15, 2021
@elasticsearchmachine elasticsearchmachine added the external-contributor Pull request authored by a developer outside the Elasticsearch team label Jun 15, 2021
@a03nikki a03nikki added the >docs General docs changes label Jun 15, 2021
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Jun 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@a03nikki a03nikki added the :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache label Jun 15, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jun 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Contributor

@lockewritesdocs lockewritesdocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lockewritesdocs lockewritesdocs merged commit e124824 into elastic:master Jun 16, 2021
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Jun 16, 2021
@lockewritesdocs lockewritesdocs removed the external-contributor Pull request authored by a developer outside the Elasticsearch team label Jun 16, 2021
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Jun 16, 2021
lockewritesdocs pushed a commit that referenced this pull request Jun 16, 2021
…nstext.cache_*` in documentation. (#74144) (#74182)

Co-authored-by: Nicole Albee <[email protected]>
lockewritesdocs pushed a commit that referenced this pull request Jun 16, 2021
…nstext.cache_*` in documentation. (#74144) (#74184)

Co-authored-by: Nicole Albee <[email protected]>
@a03nikki a03nikki deleted the fix/doc-script-context-settings branch June 16, 2021 14:28
limingnihao pushed a commit to limingnihao/elasticsearch that referenced this pull request Jun 17, 2021
* master: (284 commits)
  [DOCS] Update central reporting image (elastic#74195)
  [DOCS] SQL: Document `null` handing for string functions (elastic#74201)
  Fix Snapshot Docs Listing Query Params in Body Incorrectly (elastic#74196)
  [DOCS] EQL: Note EQL uses `fields` parameter (elastic#74194)
  Mute failing MixedClusterClientYamlTestSuiteIT test {p0=indices.split/20_source_mapping/Split index ignores target template mapping} test (elastic#74198)
  Cleanup Duplicate Constants in Snapshot XContent Params (elastic#74114)
  [DOC] Add watcher to the threadpool doc (elastic#73935)
  [Rest Api Compatibility] Validate Query typed api (elastic#74171)
  Replace deprecated `script.cache.*` settings with `script.context.$constext.cache_*` in documentation. (elastic#74144)
  Pin Alpine Linux version in Docker builds (elastic#74169)
  Fix clone API settings docs bug (elastic#74175)
  [ML] refactor internal datafeed management (elastic#74018)
  Disable query cache for FunctionScoreQuery and ScriptScoreQuery (elastic#74060)
  Fork the sending of file chunks during recovery (elastic#74164)
  RuntimeField.Builder should not extend FieldMapper.Builder (elastic#73840)
  Run CheckIndex on metadata index before loading (elastic#73239)
  Deprecate setting version on analyzers (elastic#74073)
  Add test with null transform id in stats request (elastic#74130)
  Order imports when reformatting (elastic#74059)
  Move deprecation code from xpack core to deprecation module. (elastic#74120)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >docs General docs changes Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants