[ML][Inference] adjusting definition object schema and validation #47447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
benwtrent
commented
Oct 2, 2019
benwtrent
commented
- Adds Input object for model definition
- Adjusts field names to match schema
- Removes the same field name validations and require ensemble to pass down the field map object
- Adjusts field values processing to be resilient against different numeric types.
|
Pinging @elastic/ml-core (:ml) |
|
@elasticmachine update branch |
…nce-obj-fixup-schema-update
….com:benwtrent/elasticsearch into feature/ml-inference-obj-fixup-schema-update
przemekwitek
reviewed
Oct 7, 2019
| private final List<String> featureNames; | ||
|
|
||
| public Input(List<String> featureNames) { | ||
| this.featureNames = featureNames; |
There was a problem hiding this comment.
I think you should either put requireNonNull here or add if statement in line 186.
...gin/core/src/main/java/org/elasticsearch/xpack/core/ml/inference/TrainedModelDefinition.java
Show resolved
Hide resolved
...t-high-level/src/main/java/org/elasticsearch/client/ml/inference/TrainedModelDefinition.java
Show resolved
Hide resolved
| put("foo", 0.3); | ||
| put("bar", null); | ||
| }}; | ||
| assertEquals(0.1, tree.infer(featureMap), 0.00001); |
There was a problem hiding this comment.
Replace assertEquals with assertThat(..., closeTo(...))?
...gin/core/src/main/java/org/elasticsearch/xpack/core/ml/inference/trainedmodel/tree/Tree.java
Show resolved
Hide resolved
przemekwitek
approved these changes
Oct 7, 2019
...gin/core/src/main/java/org/elasticsearch/xpack/core/ml/inference/trainedmodel/tree/Tree.java
Show resolved
Hide resolved
| put("foo", 0.3); | ||
| put("bar", null); | ||
| }}; | ||
| assertEquals(1.0, tree.infer(featureMap), 0.00001); |
| @@ -336,6 +329,12 @@ public void testClassificationInference() { | |||
| featureVector = Arrays.asList(0.0, 1.0); | |||
| featureMap = zipObjMap(featureNames, featureVector); | |||
| assertEquals(1.0, ensemble.infer(featureMap), 0.00001); | |||
|
run elasticsearch-ci/1 |
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Oct 7, 2019
…astic#47447) * [ML][Inference] adjusting definition object schema and validation * finalizing schema and fixing inference npe * addressing PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.