Use serializable exception in GCP listeners #33657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used TimeoutException here but that's not serializable. This commit switches to a serializable exception so that we can test for the exception type on the remote side.
jasontedor
added
>non-issue
review
v7.0.0
:Distributed Indexing/Distributed
|
Pinging @elastic/es-distributed |
jasontedor
added a commit
that referenced
this pull request
Sep 13, 2018
We used TimeoutException here but that's not serializable. This commit switches to a serializable exception so that we can test for the exception type on the remote side.
jasontedor
added a commit
that referenced
this pull request
Sep 13, 2018
This reverts commit 6dfe54c.
jasontedor
added a commit
that referenced
this pull request
Sep 13, 2018
This reverts commit 6dfe54c.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Sep 13, 2018
…polling * elastic/master: SQL: Return correct catalog separator in JDBC (elastic#33670) [CCR] Add validation for max_retry_delay (elastic#33648) [CCR] Add monitoring mapping verification test (elastic#33662) CORE: Disable Setting Type Validation (elastic#33660) (elastic#33669) Revert "Use serializable exception in GCP listeners (elastic#33657)" Adding index refresh (elastic#33647) [DOCS] Moves securing-communications to docs (elastic#33640) [HLRC][ML] Add ML delete datafeed API to HLRC (elastic#33667) Mute testRecoveryWithConcurrentIndexing TEST: decrease logging level in the flush test DOC: Add SQL section on client applications Fix race in global checkpoint listeners test Use serializable exception in GCP listeners (elastic#33657)
|
I have removed the version labels and reverted this change because I went with a different approach in the use case I had so that I do not need to worry about whether or not these exceptions are serializable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used TimeoutException here but that's not serializable. This commit switches to a serializable exception so that we can test for the exception type on the remote side.
Relates #33620