Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix createComponents signature in APM-Data plugin #101578

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

tvernum
Copy link
Contributor

@tvernum tvernum commented Oct 31, 2023

Relates: #97546, #101305

@tvernum tvernum requested a review from axw October 31, 2023 05:39
@tvernum tvernum requested a review from a team as a code owner October 31, 2023 05:39
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Oct 31, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)


private final SetOnce<APMIndexTemplateRegistry> registry = new SetOnce<>();

public APMPlugin(Settings settings) {
this.settings = settings;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dropped this because it's actually a bug. The settings object that's passed in the constructor should only ever be used in the constructor - everything later in the lifecycle should use the settings from environment.

@tvernum
Copy link
Contributor Author

tvernum commented Oct 31, 2023

I'm going to merge before CI completes as the PR is reviewed & the build is currently broken.

@tvernum tvernum merged commit c7ddfef into elastic:main Oct 31, 2023
2 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>non-issue Team:Data Management Meta label for data/management team v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants