Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit shard failures accumulated by searches #99220

Open
Tracked by #77466
DaveCTurner opened this issue Sep 6, 2023 · 2 comments
Open
Tracked by #77466

Limit shard failures accumulated by searches #99220

DaveCTurner opened this issue Sep 6, 2023 · 2 comments
Assignees
Labels
>enhancement :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch

Comments

@DaveCTurner
Copy link
Contributor

DaveCTurner commented Sep 6, 2023

Today we create an array of size getNumShards() to collect shard failures received during a search (on the first failure):

At high shard counts this array itself could be pretty large, and if a substantial number of shards fail then its contents will become massive. I'm pretty sure we don't need to accumulate all the failures in this situation, they're almost certainly not useful for the end-user or even for debugging. Could we instead just just track the first few failures and keep a count of the rest?

Relates #77466

@DaveCTurner DaveCTurner added >enhancement :Search/Search Search-related issues that do not fall into other categories labels Sep 6, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Sep 6, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@quux00 quux00 self-assigned this Nov 10, 2023
@javanna javanna added :Search Foundations/Search Catch all for Search Foundations and removed :Search/Search Search-related issues that do not fall into other categories labels Jul 17, 2024
@elasticsearchmachine elasticsearchmachine added Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch and removed Team:Search Meta label for search team labels Jul 17, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch
Projects
None yet
Development

No branches or pull requests

5 participants
@quux00 @javanna @DaveCTurner @elasticsearchmachine and others