Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Aggregator#buildTopLevel() to search worker thread. #98705

Closed
martijnvg opened this issue Aug 22, 2023 · 1 comment · Fixed by #98715
Closed

Move Aggregator#buildTopLevel() to search worker thread. #98705

martijnvg opened this issue Aug 22, 2023 · 1 comment · Fixed by #98715
Assignees
Labels
:Analytics/Aggregations Aggregations >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@martijnvg
Copy link
Member

As part of #98204, aggregation post collection was moved to the search worker thread in the ContextIndexSearcher class.
We should do the same for building top level internal aggregations. The reason for this is that depending on the aggregation implementation that can be an expensive operation and all expensive search related operations should occur on a search worker thread.

The AggregationPhase should just be the place that reduces the top level internal aggregations from the different slices.
An idea is that post collection of the top level aggregations should perhaps also build the internal aggregations? Then AggregationPhase can just use that directly (instead of building it).

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Aug 22, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants