-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add ECS-mappings compatibility tests #96713
Comments
Pinging @elastic/es-data-management (Team:Data Management) |
@mark-vieira this issue is not scheduled yet for implementation, but some guidance would be helpful to have in advance:
|
If you want to run as part of Elasticsearch CI then reimplementing as JUnit test would be the preferable solution.
That's fine. I also think they could just as well live inside the
That's probably fine although I wonder if we'll want to version this. Pointing at a file in |
These tests are our way to verify that the ECS dynamic templates keep up with changes in ECS, so we always want to rely on main and fail if new ECS fields are not covered by these templates. We expect that such failures will be rare and the test would be stable, but if we find out this is not the case we can try something else. |
#96171 added dynamic templates that cover all ECS mappings.
Those were enhanced by #96712 to be applicable with
subobjects: false
as well.@P1llus wrote a test that scans ECS mapping artifact, creates a document with all ECS-matching fields, indexes it and verifies that all mappings are as expected.
We want to add this to CI so that it runs on a weekly basis, thus tests regressions in our ECS templates as well as notifying us when ECS gets updated in such a way that requires modification of the dynamic templates.
cc @felixbarny @ruflin
The text was updated successfully, but these errors were encountered: