Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track distribution of REST response sizes #84887

Open
Tracked by #77466
DaveCTurner opened this issue Mar 10, 2022 · 2 comments
Open
Tracked by #77466

Track distribution of REST response sizes #84887

DaveCTurner opened this issue Mar 10, 2022 · 2 comments
Labels
:Core/Infra/REST API REST infrastructure and utilities >enhancement Team:Core/Infra Meta label for core/infra team

Comments

@DaveCTurner
Copy link
Contributor

Description

It would sometimes be useful to know whether a cluster is returning humongous REST responses when diagnosing performance issues. We could do this by tracking the distribution of REST response sizes in the HTTP stats of each node. A simple fixed-bucket powers-of-two histogram would be a powerful addition.

Relates #77466

@DaveCTurner DaveCTurner added >enhancement :Core/Infra/REST API REST infrastructure and utilities labels Mar 10, 2022
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Mar 10, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@stu-elastic
Copy link
Contributor

In scripting we found it useful to provide a counter with a sliding window for scripting compilation rate limits so users could see events in a 5m/15m/24h time frame. A strictly increasing counter requires the user to do the snapshotting themselves, the code for implementing that is in TimeSeriesCounter. Perhaps that could be combined with a histogram to provide better introspection for these cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/REST API REST infrastructure and utilities >enhancement Team:Core/Infra Meta label for core/infra team
Projects
None yet
Development

No branches or pull requests

5 participants