-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we move the "version" field under the "keyword" family type #83594
Comments
Pinging @elastic/es-search (Team:Search) |
Adding some background: we had a discussion while adding the new version type, and at the time didn't think it made sense to add to the |
I understand the reason behind the decision and it seems logic to keep it outside of the One additional comment I want to make though, maybe this will come up in future discussions for other data types: the cost of adding support for one data type in QL in general (EQL, SQL or any other future language) is significant. There is a cost that is common to all languages but there are aspects that are unique to each language that need to be considered. |
Thanks, thats the route we will take after another team discussion.
Thanks for raising that concern again, it will be on our mind, the cost of adding new field types is also non-neligible on our end so we try to keep away from having to do that as much as possible. There are cases though where it makes sense, so we will think a lot about family-type compatibility in the future. |
When we introduced the
version
field type for semantic version strings, we aimed at making it compatible with the "keyword" field type. However, currently the field type has its own "type" name in the_field_caps
output. The QL team recently got requests for support of this field type and apparently if a field type is added in an existent family that QL already supports, it makes that new field type being supported by default. We might want to consider movingversion
under thekeyword
family as well.I'm opening this issue for discussion especially around backward compatibility concerns and to check if the field type really meets the requirements that are necessary to be moved under the
keyword
family. For example, we recently saw that_terms_enum
currently isn't supported for this field type (#83403).The text was updated successfully, but these errors were encountered: