Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we make _ignored retrievable via fields? #74229

Closed
cbuescher opened this issue Jun 17, 2021 · 4 comments
Closed

Should we make _ignored retrievable via fields? #74229

cbuescher opened this issue Jun 17, 2021 · 4 comments
Labels
>enhancement :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team

Comments

@cbuescher
Copy link
Member

cbuescher commented Jun 17, 2021

We started adding metadata field like _size and _doc_count (#70575) or
the new _tier field (#71379) to the list of metadata retrievable via the fieldsAPI.
We might also want to add the _ignored field here, which currently doesn't support fetching via fields, but it might make
sense in light of issues like #74121 to add this.

@cbuescher cbuescher added >enhancement :Search/Search Search-related issues that do not fall into other categories labels Jun 17, 2021
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Jun 17, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@jtibshirani
Copy link
Contributor

jtibshirani commented Jun 18, 2021

If a document has any ignored fields, the search hit always contains a section "_ignored": [ "field1", "field2", ...]. Would support for loading _ignored through fields bring additional benefit?

@jimczi
Copy link
Contributor

jimczi commented Jun 18, 2021

I agree with Julie, the _ignored section that is returned in search hit is not optional. It is always there if the hit has ignored fields. We should make sure that this section covers every case (#74228) but it's not part of the fields option. It's a feature of the search that guarantees that these fields are always visible in search responses.

@cbuescher
Copy link
Member Author

Makes, sense, thanks for the quick feedback. I will close this issue then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team
Projects
None yet
Development

No branches or pull requests

4 participants