Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check contexts for nondeterminism to ensure cacheability #50341

Closed
stu-elastic opened this issue Dec 18, 2019 · 2 comments
Closed

Check contexts for nondeterminism to ensure cacheability #50341

stu-elastic opened this issue Dec 18, 2019 · 2 comments
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >enhancement Team:Core/Infra Meta label for core/infra team

Comments

@stu-elastic
Copy link
Contributor

Related: #49466 which handles nondeterminism for whitelist methods

As a future-proofing measure, we should detect when contexts provide non-deterministic classes and methods.

A sketch:
ScriptClassInfo we need to check the executeArguments for nondeternism. So, in SClass.analyze when creating the ScriptRoot we can check to see if executeArguments is all deterministic. This can be done in ScriptClassinfo ie add ScriptClassinfo.areExecuteArgumentsDeterministic or inside SClass. The result should be passed to the ScriptRoot instance via markNonDeterministic.
@stu-elastic stu-elastic added >enhancement :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache labels Dec 18, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Scripting)

@rjernst rjernst added the Team:Core/Infra Meta label for core/infra team label May 4, 2020
@rjernst rjernst added the needs:triage Requires assignment of a team area label label Dec 3, 2020
@jdconrad
Copy link
Contributor

jdconrad commented Dec 9, 2020

Done.

@jdconrad jdconrad closed this as completed Dec 9, 2020
@stu-elastic stu-elastic removed the needs:triage Requires assignment of a team area label label Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >enhancement Team:Core/Infra Meta label for core/infra team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rjernst @jdconrad @elasticmachine @stu-elastic