Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename EstimateMemoryUsage API response's fields #45741

Closed
przemekwitek opened this issue Aug 20, 2019 · 1 comment · Fixed by #45719
Closed

Rename EstimateMemoryUsage API response's fields #45741

przemekwitek opened this issue Aug 20, 2019 · 1 comment · Fixed by #45719
Labels
:ml Machine learning >refactoring

Comments

@przemekwitek
Copy link
Contributor

przemekwitek commented Aug 20, 2019 •
edited
Loading

Shorten response's fields names:

  • Rename expected_memory_usage_with_one_partition to expected_memory_without_disk
  • Rename expected_memory_usage_with_max_partitions to expected_memory_with_disk

This should be done in phases:

  1. Mute tests that may be affected
  2. Merge in C++ part (Rename memory usage estimation result fields. ml-cpp#601)
  3. Merge in Java part (Shorten field names in EstimateMemoryUsageResponse #45719)
  4. Unmute tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:ml Machine learning >refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Shorten field names in EstimateMemoryUsageResponse przemekwitek/elasticsearch
2 participants
@elasticmachine @przemekwitek