-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to use the high level rest client with modularized (jigsaw) applications #38299
Comments
Pinging @elastic/es-core-infra |
Pinging @elastic/es-core-features |
Any news about it, or a known workaround? |
Sorry @laurent-thiebaud-gisaia, no updates so far. |
Any updates on this? |
This just bit me as well. Considering that Java 9 was released over three years ago, and JPMS is not going away, can't we please get a fix for this? |
Just to clarify, you can use the HLRC in conjunction with a application that leverages JPMS, it just has to be placed on the classpath and not the module path, yes? |
@mark-vieira no, as soon as one of your modules on the module path uses the code of the HLRC that HLRC jar needs to be on the modulepath. At least as automatic module or of course as explicit module. |
Understood. We could in theory shade the elasticsearch JAR into the HLRC JAR, at which point JPMS should be happy as all the |
Any updates or workaround? |
The HLRC has been replaced with the new Java client. The new client has no dependency on Elasticsearch so this is no longer an issue. |
Right now it's not possible to write a modularized java application that talks with Elasticsearch using the High Level Rest Client. This came out of the discussion in #28984.
Since the HLRC depends on server, the application has to
require elasticsearch
because some of the classes that one would use are in Server, likeSearchSourceBuilder
.This won't work because server also has an
org.elasticsearch.client
package.The Module system doesn't allow this.
There are other modules that one would have to require, like
org.apache.http.HttpHost
so these will also have to work as modules.The text was updated successfully, but these errors were encountered: