Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] NamedDateTimeProcessorTests fails #33621

Closed
vladimirdolzhenko opened this issue Sep 12, 2018 · 6 comments
Closed

[CI] NamedDateTimeProcessorTests fails #33621

vladimirdolzhenko opened this issue Sep 12, 2018 · 6 comments
Assignees
Labels
:Analytics/SQL SQL querying >test-failure Triaged test failures from CI v6.5.0 v7.0.0-beta1

Comments

@vladimirdolzhenko
Copy link
Contributor

vladimirdolzhenko commented Sep 12, 2018

Log: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+matrix-java-periodic/ES_BUILD_JAVA=java11,ES_RUNTIME_JAVA=java10,nodes=virtual&&linux/297/console

Quite well reproduced locally with

./gradlew :x-pack:plugin:sql:test -Dtests.seed=8648CDF8F6D4BBCC -Dtests.class=org.elasticsearch.xpack.sql.expression.function.scalar.datetime.NamedDateTimeProcessorTests -Dtests.method="testValidMonthNamesInUTC" -Dtests.security.manager=true -Dtests.locale=fr-ML -Dtests.timezone=America/Asuncion -Dcompiler.java=11 -Druntime.java=10
05:45:03 FAILURE 0.01s J1 | NamedDateTimeProcessorTests.testValidMonthNamesInUTC <<< FAILURES!
05:45:03    > Throwable #1: org.junit.ComparisonFailure: expected:<Jan[uary]> but was:<Jan[]>
05:45:03    > 	at __randomizedtesting.SeedInfo.seed([8648CDF8F6D4BBCC:5B6DAFD26B51202D]:0)
05:45:03    > 	at org.elasticsearch.xpack.sql.expression.function.scalar.datetime.NamedDateTimeProcessorTests.testValidMonthNamesInUTC(NamedDateTimeProcessorTests.java:67)
05:45:03    > 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
05:45:03    > 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
05:45:03    > 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
05:45:03    > 	at java.base/java.lang.reflect.Method.invoke(Method.java:564)
05:45:03    > 	at java.base/java.lang.Thread.run(Thread.java:844)

Relates to #33411

@vladimirdolzhenko vladimirdolzhenko added >test-failure Triaged test failures from CI :Analytics/SQL SQL querying labels Sep 12, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@astefan astefan self-assigned this Sep 12, 2018
@astefan
Copy link
Contributor

astefan commented Sep 12, 2018

After digging into this one, this is specific to Java 9+. The change that makes the day names be returned in narrow format (as opposed to FULL) is documented here.

@astefan
Copy link
Contributor

astefan commented Sep 12, 2018

ES is already using -Djava.locale.providers=COMPAT but the testing infra doesn't pass this one to the forked jvm for the test.

@DaveCTurner
Copy link
Contributor

I marked these tests as @AwaitsFix in master in 44a80d6.

@DaveCTurner
Copy link
Contributor

Bah, @vladimirdolzhenko already did so in cfc2082, but I didn't realise. Reverted in 94f6d45.

@cbuescher
Copy link
Member

These tests were not muted on 6.x and continued failing, I pushed an @Awaitsfix with 68aff71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/SQL SQL querying >test-failure Triaged test failures from CI v6.5.0 v7.0.0-beta1
Projects
None yet
Development

No branches or pull requests

6 participants