-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create jvm options dsl and generator in gradle #32257
Comments
Pinging @elastic/es-core-infra |
@rjernst what is the advantage of the DSL vs reading the file and passing in the arguments for the tests ? We could expose it trough a configuration on the relevant project and make it a proper dependency if you are concerned about locating it. |
The file has a syntax that is not simple to read (we have our own parser so we can have options specific to a java version). Since we need this at gradle configuration time, we would have a chicken/egg problem because to reuse that parser would mean already having compiled the parser. |
this issue should also be taken into account #48222 |
Also related: #46118 (comment) |
I think this is even less compelling with the addition of auto heap sizing so we've reduced the need for folks to touch the |
Elasticsearch has a text file called jvm.options which is pretty much a line delimited set of additional command line arguments for java when invoked by
bin/elasticsearch
(with the caveat it has version specific conditionals to allow eg java 9 specific options). While the integration tests, by virtue of runningbin/elasticsearch
, use these options, the unit tests do not. This issue is intended to outline a proposal for how unit tests can use these options, without the need for duplication across gradle and the jvm.options text file.The proposal is to move the specification of the jvm options we ship with into gradle itself. That would allow the unit tests to consume the dsl (or rather, the dsl can fan it's configured settings out to all RandomizedTestTasks or something like that), and the shipped jvm.options file can be generated from the dsl as part of the distribution build.
The text was updated successfully, but these errors were encountered: