Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid negative values for "weight" in Function Score Query #31927

Closed
mayya-sharipova opened this issue Jul 10, 2018 · 6 comments
Closed

Forbid negative values for "weight" in Function Score Query #31927

mayya-sharipova opened this issue Jul 10, 2018 · 6 comments
Labels
blocker >enhancement good first issue low hanging fruit help wanted adoptme :Search/Search Search-related issues that do not fall into other categories v7.0.0-beta1

Comments

@mayya-sharipova
Copy link
Contributor

mayya-sharipova commented Jul 10, 2018 •
edited
Loading

If a negative weight is submitted for a query:

  • issue a deprecation message for 6.x
  • error for 7

related to #24910
@mayya-sharipova mayya-sharipova changed the title Forbid negative values for weight in Function Score Query Forbid negative values for "weight" in Function Score Query Jul 10, 2018
@mayya-sharipova mayya-sharipova added good first issue low hanging fruit :Search/Search Search-related issues that do not fall into other categories labels Jul 10, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@mayya-sharipova mayya-sharipova mentioned this issue Jul 10, 2018
Closed
@aditya-agrawal
Copy link
Contributor

Hi, I would like to pick this issue.

@mayya-sharipova
Copy link
Contributor Author

Thanks @aditya-agrawal, your PR would be very much appreciated

@mayya-sharipova
Copy link
Contributor Author

@aditya-agrawal We have an urgent need for this PR, as we are preparing for Lucene 8 upgrade. Do you think you will be able to submit a PR within several days?

If not, no problem, we can work on it ourselves.

@jimczi jimczi mentioned this issue Aug 24, 2018
Closed
18 tasks
@aditya-agrawal
Copy link
Contributor

@mayya-sharipova yes I will try to complete this in few days.

@lipsill lipsill mentioned this issue Sep 4, 2018
Merged
@lipsill lipsill mentioned this issue Sep 12, 2018
Merged
jimczi pushed a commit that referenced this issue Sep 14, 2018
@lipsill @jimczi
Deprecate negative weight in Function Score Query (#33624)
76799bb 
This change issues a deprecation message for negative
`weight` in Function Score query. This is a preparation
for Lucene 8 (used in 7.0) where negative scores are forbidden.

Closes #31927
@jimczi
Copy link
Contributor

jimczi commented Sep 14, 2018

Closed by #33390

@jimczi jimczi closed this as completed Sep 14, 2018
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
@NikolayBorovenskiy NikolayBorovenskiy mentioned this issue Aug 11, 2020
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker >enhancement good first issue low hanging fruit help wanted adoptme :Search/Search Search-related issues that do not fall into other categories v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mayya-sharipova @aditya-agrawal @elasticmachine @jimczi