Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cloud plugins to have real mocks for tests #12719

Closed
clintongormley opened this issue Aug 7, 2015 · 5 comments
Closed

Fix cloud plugins to have real mocks for tests #12719

clintongormley opened this issue Aug 7, 2015 · 5 comments
Labels
:Core/Infra/Plugins Plugin API and infrastructure Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests

Comments

@clintongormley
Copy link
Contributor

  • These only have shallow tests and are fragile. we rely on users to report bugs
  • need disco test in qa/ with mock ec2
  • need snapshot test in qa/ with mock s3
  • ideally use proxy too for testing that
@clintongormley clintongormley added >test Issues or PRs that are addressing/adding tests help wanted adoptme :Core/Infra/Plugins Plugin API and infrastructure labels Aug 7, 2015
@clintongormley clintongormley mentioned this issue Aug 10, 2015
Closed
16 tasks
@clintongormley
Copy link
Contributor Author

@jasontedor please could you try to tackle this one

@dadoonet
Copy link
Member

@clintongormley @jasontedor FYI I'm currently working on ec2 mock

@s1monw
Copy link
Contributor

s1monw commented Aug 12, 2015

@dadoonet can you sync with @jasontedor on this please

@clintongormley clintongormley mentioned this issue Aug 13, 2015
Closed
@jasontedor jasontedor removed the help wanted adoptme label Aug 16, 2015
@jasontedor jasontedor removed their assignment Jan 1, 2016
@dadoonet
Copy link
Member

For the record, @ywelsch just added some new tests for EC2 with #17677
@s1monw already added tests for GCE with #16881

@rjernst rjernst added the Team:Core/Infra Meta label for core/infra team label May 4, 2020
@rjernst rjernst added the needs:triage Requires assignment of a team area label label Dec 3, 2020
@williamrandolph
Copy link
Contributor

I believe this work has been handled in #31107 and #29315.

@williamrandolph williamrandolph removed the needs:triage Requires assignment of a team area label label Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Core/Infra/Plugins Plugin API and infrastructure Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@clintongormley @dadoonet @rjernst @s1monw @williamrandolph @jasontedor