Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove limitation of using full text functions after LIMIT #115297

Open
ioanatia opened this issue Oct 22, 2024 · 3 comments
Open

Remove limitation of using full text functions after LIMIT #115297

ioanatia opened this issue Oct 22, 2024 · 3 comments
Labels
ES|QL-ui Impacts ES|QL UI :Search Relevance/Search Catch all for Search Relevance Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch

Comments

@ioanatia
Copy link
Contributor

When using match or qstr after limit we are returning an error that indicates this is not currently supported:

FROM kibana_sample_data_logs
| LIMIT 10000 
| WHERE MATCH(geo.dest, \"CN\")

In Kibana, in order to suggest values for filters, we construct a query similar to:

FROM kibana_sample_data_logs
| LIMIT 10000
| WHERE MATCH(geo.dest, \"CN\")
| WHERE `geo.src` IS NOT NULL
| STATS `geo.src_terms` = count(`geo.src`) BY `geo.src`
| SORT `geo.src_terms` DESC\n 
| LIMIT 10

This query would return suggested values for the geo.src field:

Image

Because of the limitation we have for match where it cannot be used after limit, Kibana will return an error when it tries to suggest values for filters:

Image

related elastic/kibana#196995

Kibana is one use case that would benefit from removing this limitation.
We can expect that ES|QL users will also hit it in other contexts.

@ioanatia ioanatia added :Search Relevance/Search Catch all for Search Relevance ES|QL-ui Impacts ES|QL UI Team:Search Meta label for search team labels Oct 22, 2024
@elasticsearchmachine elasticsearchmachine added Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch and removed Team:Search Meta label for search team labels Oct 22, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/kibana-esql (ES|QL-ui)

@ChrisHegarty
Copy link
Contributor

For now, and until this issue is resolved, the match and qstr functions will be held to snapshot builds in 8.x, see #115253.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ES|QL-ui Impacts ES|QL UI :Search Relevance/Search Catch all for Search Relevance Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch
Projects
None yet
Development

No branches or pull requests

3 participants