Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use real memory circuit breaker when running Elasticsearch from source #102470

Open
iverase opened this issue Nov 22, 2023 · 4 comments
Open

Use real memory circuit breaker when running Elasticsearch from source #102470

iverase opened this issue Nov 22, 2023 · 4 comments
Labels
:Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch :Core/Infra/Circuit Breakers Track estimates of memory consumption to prevent overload Team:Clients Meta label for clients team Team:Core/Infra Meta label for core/infra team

Comments

@iverase
Copy link
Contributor

iverase commented Nov 22, 2023

During development I often run elasticsearch from source using ./gradlew run. While working with the real real memory circuit breaker I noticed that it is disable when running in this mode and it is not allow to use it:

Execution failed for task ':run'.
> Testclusters does not allow the following settings to be changed:[indices.breaker.total.use_real_memory] for node{::runTask-0}

The issue is the following line and commenting it out makes the clsuter work with the circuit breaker:

baseConfig.put("indices.breaker.total.use_real_memory", "false");

I am wondering if we can revise this restriction and if it is obsolete, allow to run test clusters with the real memory circuit breaker.

@iverase iverase added the :Core/Infra/Circuit Breakers Track estimates of memory consumption to prevent overload label Nov 22, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Nov 22, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@thecoop
Copy link
Member

thecoop commented Nov 28, 2023

This was originally set as part of #31986, due to limitations in clients

@thecoop thecoop added the :Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch label Nov 28, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Clients Meta label for clients team label Nov 28, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/clients-team (Team:Clients)

@thecoop
Copy link
Member

thecoop commented Nov 28, 2023

@elastic/clients-team is the restriction in

// Temporarily disable the real memory usage circuit breaker. It depends on real memory usage which we have no full control
still applicable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch :Core/Infra/Circuit Breakers Track estimates of memory consumption to prevent overload Team:Clients Meta label for clients team Team:Core/Infra Meta label for core/infra team
Projects
None yet
Development

No branches or pull requests

3 participants