-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate support for Panama Vector and FFI #101314
Comments
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Is there a reason to do this rather than just use the real JDK? Our build can already auto-provision JDKs so this isn't a big deal. |
Yes, but of course we have options. There are two issues that the api jar solves beyond the compile JDK:
For no.1 we could just support jdk22+, but that delays work waiting for this. Maybe we can look at this in the future. Alternatively, we could compile with For no.2 we could just disable I chose to "just do the same as Lucene" so as to avoid creating something new, but the above does not seem too onerous. No.3 is a little more sensitive, and is probably the strongest reason to use the api jar. |
Understood, that makes sense. |
@ChrisHegarty I think this issue has been addressed by the mrjar plugin, would you agree? |
We have have FFI - yay!! But we don't have the incubating Vector API. Maybe we can live without that for now. |
This issue proposed to add support to Elasticsearch for the previewing/incubating Panama Vector and FFI.
The most fruitful approach is to follow that we've already done in Lucene - it is tried, tested, and proven to work well. That is:
src/java21
.It's worth nothing that in Lucene my IDE setup for version specific source code, e.g.
src/java21
, is not great - I get red squiggly lines under the code that is newer than JDK 17. But it's not too bad - there are workarounds by setting local JDKs. But maybe we can do something better?blocks #98749
The text was updated successfully, but these errors were encountered: