Handling visibility=private

[lcawl]

In #3299 I noticed that one of the operations has visibility=private:

* @availability stack since=5.4.0 stability=stable visibility=private
 * @availability serverless stability=stable visibility=private

It is appropriately omitted from the Serverless OpenAPI document, however it appears in the stack openAPI document: https://www.elastic.co/docs/api/doc/elasticsearch/operation/operation-ml-validate

Is this disparity because the filter-for-serverless make command (

elasticsearch-specification/Makefile

Line 54 in fb25929

filter-for-serverless: ## Generate the serverless version from the compiled schema

) has filter-by-availability -- --serverless --visibility=public? If so, where would be the appropriate place to add a similar filter on the other output file?

[Anaethelion]

The source of the filter seems to come from:

elasticsearch-specification/compiler-rs/compiler-wasm-lib/src/lib.rs

Lines 30 to 41 in b2ad226

	let filter: Option<fn(&Option<Availabilities>) -> bool> = match flavor {
	"all" => None,
	"stack" => Some(|a| {
	// Generate public and private items for Stack
	clients_schema::Flavor::Stack.available(a)
	}),
	"serverless" => Some(|a| {
	// Generate only public items for Serverless
	clients_schema::Flavor::Serverless.visibility(a) == Some(Visibility::Public)
	}),
	_ => bail!("Unknown flavor {}", flavor),
	};

I'll change the filter to match serverless!

[swallez]

@Anaethelion I'm on it, finishing the tests before the PR

[swallez]

Stack clients also contain private API endpoints, and we reused that policy for the OpenAPI export, which is wrong as it's used to produce the public docs. Fixed in PR #3308